WIP: add test sample with zone-testing

modules/core/internal/create/combineLatest-spec.ts

@@ -1,7 +1,17 @@
 import { of } from "./of";
 import { combineLatest } from "./combineLatest";
+import { Observable } from "../Observable";
+
+function createIntervalObservable(interval: number) {
+ return new Observable<number>(subscriber => {
+ let i = 0;
+ const id = setInterval(() => {
+ subscriber.next(i++);
+ }, interval);
+ return () => clearInterval(id);
+ });
+}
 
-// TODO: write a zone.js test to cover this with a timer
 describe('combineLatest', () => {
  it('should combine the latest values of multiple observables', () => {
  const results: any[] = [];
@@ -14,5 +24,36 @@ describe('combineLatest', () => {
  next(value) { results.push(value); },
  complete() { results.push('done'); },
  });
+ expect(results).toEqual([[1, 2, 3]]);
  });
+
+ it('should combine the latest values of multiple observables with fakeAsync', fakeAsyncTest(() => {
+ const results: any[] = [];
+ const s1 = createIntervalObservable(1000);
+ const s2 = createIntervalObservable(1500);
+ const s3 = createIntervalObservable(1800);
+ combineLatest(s1, s2, s3).subscribe({
+ next(value) { results.push(value); },
+ complete() { results.push('done'); },
+ });
+ expect(results).toEqual([]);
+ tick(1000);
+ expect(results).toEqual([]);
+ tick(500);
+ expect(results).toEqual([]);
+ tick(300);
+ expect(results).toEqual([[0, 0, 0]]);
+ tick(300);
+ expect(results).toEqual([[0, 0, 0], [1, 0, 0]]);
+ clearAllMacrotasks();
+ }));
+
+ it('Date.now should be advanced by fakeAsyncTest', fakeAsyncTest(() => {
+ const start = Date.now();
+ tick(100);
+ const end = Date.now();
+ expect(end - start).toBe(100);
+ }));
+
+ // TODO: Add a marble test with zone-testing.
 });

modules/core/internal/create/combineLatest.ts

@@ -29,8 +29,9 @@ export function combineLatestSource<T>(sources: ObservableInput<T>[]): Source<T>
  src(FOType.SUBSCRIBE, (t: FOType, v: SinkArg<T>, subs: Subscription) => {
  if(t === FOType.NEXT) {
  values[s] = v;
+ emittedOnce[s] = true;
  if (hasValues || (hasValues = emittedOnce.every(identity))) {
- sink(FOType.NEXT, values.slice(0), subs);
+ sink(FOType.NEXT, values.slice(), subs);
  }
  }
  }, subs);

package.json

@@ -24,8 +24,9 @@
  "watch": "Watch codebase, trigger compile when source code changes"
  },
  "scripts": {
- "test": "mocha -r ts-node/register modules/**/*-spec.ts",
+ "test": "npm run prepare-zone && mocha -r ts-node/register -r ./node_modules/zone.js/dist/zone-testing-node-bundle modules/**/*-spec.ts",
  "watch": "watch 'npm run test' modules",
+ "prepare-zone": "mkdir -p ./node_modules/@types/zone.js && cp ./node_modules/zone.js/lib/testing/zone-testing.typing.ts ./node_modules/@types/zone.js/index.d.ts",
  "build": "tsc"
  },
  "repository": {
@@ -55,7 +56,6 @@
  },
  "devDependencies": {
  "@types/chai": "^4.1.2",
- "@types/mocha": "^5.0.0",
  "chai": "^4.1.2",
  "commitizen": "^2.9.6",
  "cz-conventional-changelog": "^2.1.0",
@@ -64,6 +64,7 @@
  "ts-node": "^5.0.1",
  "tslint": "^5.9.1",
  "typescript": "^2.8.1",
- "watch": "^1.0.2"
+ "watch": "^1.0.2",
+ "zone.js": "github:JiaLiPassion/zone.js#rxjs-test-dist"
  }
 }