Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #3988 into v5 branch #3994

Closed
wants to merge 1 commit into from

Conversation

imcotton
Copy link
Contributor

@imcotton imcotton commented Aug 6, 2018

Description:
Since lots of projects not moving fast enough to upgrade to v6 along with rxjs-compat, need back port changes from #3988 into v5 branch.

Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this can be backported to v5, as that version used TypeScript 2.0 and keyof was introduced in 2.1.

@imcotton
Copy link
Contributor Author

imcotton commented Aug 6, 2018

Oh I think you're right, I was only thinking RxJS v5 together with Angular v5, forgotten that RxJS actually servers much larger range to pined with TS v2.0 series, will close this then.

@imcotton imcotton closed this Aug 6, 2018
@imcotton imcotton deleted the cp-3398-to-v5 branch August 6, 2018 20:40
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants