Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Reduce memory consumption and simplify inner and outer subscription #5610

Merged
merged 4 commits into from
Jul 30, 2020
Merged

refactor: Reduce memory consumption and simplify inner and outer subscription #5610

merged 4 commits into from
Jul 30, 2020

Commits on Jul 30, 2020

  1. refactor: simplify inner and outer subscription 

    - Reduces memory pressure by no longer capturing outer values where they are not needed. For example, every inner subscription in mergeMap was retaining the outer value, if the outer value was a large array, that could add up
- Makes subscribeToResult less ridiculous, I am not sure what I was thinking there
- Leaves a few operators with more complex inner subscriptions, to be refactored later.
- Removes some redundant code that removed inner subscriptions manually, this was necessary in the early days of RxJS 5, but has not been necessary in a long time
    @benlesh
    benlesh committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    242e87c View commit details
    Browse the repository at this point in the history

  2. chore: rename innies-and-outies :(

    @benlesh
    benlesh committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    14f1b94 View commit details
    Browse the repository at this point in the history

  3. chore: rename interface to SimpleOuterSubscriberLike

    @benlesh
    benlesh committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    5a312da View commit details
    Browse the repository at this point in the history

  4. refactor: don't retain unused outerValues in combineLatest and race

    @benlesh
    benlesh committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    7ac61cf View commit details
    Browse the repository at this point in the history