Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipUntil: fixes and tests #586

Merged
merged 3 commits into from
Nov 3, 2015
Merged

skipUntil: fixes and tests #586

merged 3 commits into from
Nov 3, 2015

Commits on Oct 30, 2015

  1. test(skipUntil): assert subscription/unsubscription 

    Add tests to skipUntil that assert when its source and notifier get
subscribed and unsubscribed.
    @staltz
    Andre Medeiros authored and staltz committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    97e2258 View commit details
    Browse the repository at this point in the history

  2. fix(skipUntil): unsubscribe source when it completes 

    Fix operator skipUntil to automatically unsubscribe from its
source whenever it completes. This is to conform RxJS Next with RxJS 4.

Resolves issue ReactiveX#577.
    @staltz
    Andre Medeiros authored and staltz committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    8a4162b View commit details
    Browse the repository at this point in the history

  3. refactor(skipUntil): call super(destination) constructor 

    Change SkipUntilSubscriber to give the destination subscriber to the
constructor in Subscriber. Adapt SkipUntilSubscriber to handle
unsubscription-on-complete correctly, by overriding unsubscribe().

Addresses ReactiveX#577.
    @staltz
    staltz committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    7d869e9 View commit details
    Browse the repository at this point in the history