Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unhandled errors in observers correctly scheduled #6118

Merged
merged 2 commits into from
Mar 13, 2021
Merged

fix: unhandled errors in observers correctly scheduled #6118

merged 2 commits into from
Mar 13, 2021

Commits on Mar 12, 2021

  1. fix: unhandled errors in observers correctly scheduled 

    - Resolves an issue where errors thrown in a handler provided as a plain function, or as part of a POJO observer, to a `subscribe` call were not being handled appropriately. They will no longer synchronously throw unless `useDeprecatedSynchronousErrorHandling` is configured to `true`.
- Removes two tests that were poorly written, and were not passing (and should never have been passing). The ground they covered is covered adequately by other tests.
    @benlesh
    benlesh committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    4b9b985 View commit details
    Browse the repository at this point in the history

  2. chore: update comments in the code

    @benlesh
    benlesh committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    c807d9c View commit details
    Browse the repository at this point in the history