Performance fixes #307
Merged
Performance fixes #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failure are the same as on master |
ashtul
previously approved these changes
Oct 28, 2021
| @@ -8,7 +8,7 @@ | |||
| #include "command.h" | |||
| #include "dep/triemap/triemap.h" | |||
|
|
|||
| #define MR_CONN_POOL_SIZE 4 | |||
| #define MR_CONN_POOL_SIZE 1 | |||
There was a problem hiding this comment.
Using a single connection we spare Redis from switching the connections it reads from and we maximize throughput.
There was a problem hiding this comment.
Maybe a small comment there on the performance impact?
Comment on lines
+195
to
+199
| RSValue *v = RS_NullVal(); | ||
| if (i + 1 < MRReply_Length(rep)) { | ||
| MRReply *val = MRReply_ArrayElement(rep, i + 1); | ||
| v = MRReply_ToValue(val); | ||
| } |
There was a problem hiding this comment.
Is this the path for the bug exposed?
There was a problem hiding this comment.
Yes, position i+1 might not exist in case of error.
ashtul
previously approved these changes
Nov 1, 2021
rafie
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.