Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after minor behavior changes #105

Merged
merged 3 commits into from
Dec 5, 2020
Merged

Fix tests after minor behavior changes #105

merged 3 commits into from
Dec 5, 2020

Conversation

ashtul
Copy link
Contributor

@ashtul ashtul commented Dec 5, 2020

  • Results order change when score is equal.
  • Error in FT.CONFIG returns an error type, not a string.

Passes on edge but not on latest.

@ashtul ashtul requested a review from rafie December 5, 2020 07:33
rafie
rafie previously approved these changes Dec 5, 2020
View reviewed changes
@rafie rafie self-requested a review December 5, 2020 09:56
@sonarcloud
Copy link

sonarcloud bot commented Dec 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 5, 2020 •
edited
Loading

Codecov Report

Merging #105 (028d108) into master (188c94c) will decrease coverage by 1.75%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   91.76%   90.00%   -1.76%     
==========================================
  Files          12       12              
  Lines        1651     1661      +10     
==========================================
- Hits         1515     1495      -20     
- Misses        136      166      +30
Impacted Files Coverage Δ
test/test.py 95.65% <53.33%> (-3.33%) ⬇️
redisearch/client.py 86.06% <0.00%> (-3.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188c94c...028d108. Read the comment docs.

@ashtul ashtul merged commit 7c7d485 into master Dec 5, 2020
@ashtul ashtul deleted the fix-test-FT.CONFIG-now-returns-an-error branch December 5, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafie rafie rafie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashtul @rafie