Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction needs to be set to false, pipeline is OK tho #119

Merged

Conversation

maguec
Copy link
Contributor

@maguec maguec commented Apr 21, 2021

If we do not set the transaction to false when adding items to the Auto completer we get the following error:

MULTI
*4
$9
FT.SUGADD
$2
ac
$7
Walmart
$3
1.0
*1
$4
EXEC
+OK
+QUEUED
*1
-ERR Blocking module command called from transaction

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #119 (d7a2900) into master (8122d94) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files          12       12           
  Lines        1700     1700           
=======================================
  Hits         1533     1533           
  Misses        167      167           
Impacted Files Coverage Δ
redisearch/auto_complete.py 93.24% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8122d94...d7a2900. Read the comment docs.

@emmanuelkeller emmanuelkeller merged commit e7721a9 into RediSearch:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants