Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FT.CREATE - support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, SKIPINITIALSCAN #144

Merged
merged 5 commits into from
Sep 9, 2021
Merged

FT.CREATE - support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, SKIPINITIALSCAN #144

merged 5 commits into from
Sep 9, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@AvitalFineRedis AvitalFineRedis linked an issue Aug 4, 2021 that may be closed by this pull request
support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, and SKIPINITIALSCAN tags on FT.CREATE #143
Closed
@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review August 4, 2021 11:06
ashtul
ashtul reviewed Sep 5, 2021
View reviewed changes
Copy link
Contributor

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One minor comment.

redisearch/client.py Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ashtul
ashtul approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@ashtul ashtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@AvitalFineRedis AvitalFineRedis merged commit 77ec182 into master Sep 9, 2021
@AvitalFineRedis AvitalFineRedis deleted the FT.CREATE_tags branch September 9, 2021 12:35
This was referenced Dec 28, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashtul ashtul ashtul approved these changes

@chayim chayim Awaiting requested review from chayim

@rafie rafie Awaiting requested review from rafie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, and SKIPINITIALSCAN tags on FT.CREATE
2 participants
@AvitalFineRedis @ashtul