Fix issue LMMS#5409. (LMMS#5413)

Fix multiple uninitialized reads.
Reflexe · Apr 4, 2020 · 335682e · 335682e
1 parent 13fd317
commit 335682e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/src/core/Song.cpp b/src/core/Song.cpp
@@ -69,6 +69,7 @@ Song::Song() :
  m_oldTicksPerBar( DefaultTicksPerBar ),
  m_masterVolumeModel( 100, 0, 200, this, tr( "Master volume" ) ),
  m_masterPitchModel( 0, -12, 12, this, tr( "Master pitch" ) ),
+ m_nLoadingTrack( 0 ),
  m_fileName(),
  m_oldFileName(),
  m_modified( false ),
@@ -79,6 +80,7 @@ Song::Song() :
  m_renderBetweenMarkers( false ),
  m_playing( false ),
  m_paused( false ),
+ m_savingProject( false ),
  m_loadingProject( false ),
  m_isCancelled( false ),
  m_playMode( Mode_None ),

diff --git a/src/core/StepRecorder.cpp b/src/core/StepRecorder.cpp
@@ -32,7 +32,8 @@ const int REMOVE_RELEASED_NOTE_TIME_THRESHOLD_MS = 70;
 
 StepRecorder::StepRecorder(PianoRoll& pianoRoll, StepRecorderWidget& stepRecorderWidget):
  m_pianoRoll(pianoRoll),
- m_stepRecorderWidget(stepRecorderWidget)
+ m_stepRecorderWidget(stepRecorderWidget),
+ m_pattern(nullptr)
 {
  m_stepRecorderWidget.hide();
 }

diff --git a/src/gui/editors/PianoRoll.cpp b/src/gui/editors/PianoRoll.cpp
@@ -152,6 +152,8 @@ PianoRoll::PianoRoll() :
  m_zoomingModel(),
  m_quantizeModel(),
  m_noteLenModel(),
+ m_scaleModel(),
+ m_chordModel(),
  m_pattern( NULL ),
  m_currentPosition(),
  m_recording( false ),