#183 Schema validation doesn't work with YAML Aliases #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Aliases are correctly dereferenced and expanded in-place by SnakeYaml. 2. Then we convert the object (usually it's a `Map`) to a string, which is passed to Jackson's Mapper. I hope to find a better way of transforming Snake-YAML results into a `JsonNode`
|
This one is time-sensitive and I can't review right now. I know @andylowry and @daffinm are busy with knowledge transfer on multi-file support. @tfesenko , maybe we should merge this, get it into API Studio for testing by our user, and complete code review next week, after your performance optimization (and hopefully with @ghillairet here to do the code review). |
|
Leaving this to you, @tfesenko |
|
Ok, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Jackson parse does not handle YAML aliases well, we first process the JSON by snake-yaml which expands aliases, then we transform expanded YAML it to a
JsonNodewhich is provided to JSON Schema validator.I have performance concerns about too many passes required for validation:
parseYaml()creates aorg.yaml.snakeyaml.nodes.NodeparseJson()uses snake-yaml to create anObject(aMap)JsonNodeJsonNodeto see if it conforms to the Swagger JSON SchemaAs discussed at today's SUM, these concerns can be addressed later.
@andylowry can you please review and try to merge ASAP?
@ghillairet can you please review too?