Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve issue #188: Connected flag in NIOHandler.java > openOutgoingConnection is not updated correctly #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Solve issue #188: Connected flag in NIOHandler.java > openOutgoingConnection is not updated correctly #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d02899d
Update NIOHandler.java
lmcdasi Jan 19, 2022
71860fc
Merge pull request #1 from lmcdasi/lmcdasi-patch-1
lmcdasi Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/gov/nist/javax/sip/stack/NIOHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ private SocketChannel openOutgoingConnection(InetAddress senderAddress,
SocketChannel clientSock = null;

boolean entered = false;
boolean connected = false;
boolean attempted = false;
try {
keyedSemaphore.enterIOCriticalSection(key);
Expand Down Expand Up @@ -368,7 +367,7 @@ private SocketChannel openOutgoingConnection(InetAddress senderAddress,
}
} finally {
if (entered) {
if (attempted && !connected)
if (attempted && (clientSock!= null && clientSock.isBlocking() && !clientSock.isConnected()))
{
// new connection is bad.
// remove from our table the socket and its semaphore
Expand Down