Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs needed: return values #70

Open
pjz opened this issue Mar 19, 2019 · 3 comments
Open

Docs needed: return values #70

pjz opened this issue Mar 19, 2019 · 3 comments

Comments

@pjz
Copy link
Contributor

pjz commented Mar 19, 2019

The command documentation is really nice; if all else fails, I can read the code (which is well documented). What's less documented is the return values and the types of the return values... could someone take a swing at that?

@Revolution1
Copy link
Owner

Revolution1 commented Mar 20, 2019

The return type of these api are dynamically generated class from the swagger specs.

So it's kinda hard to document. Cause when I doc a rtype like :rtype: etcdserverpbSnapshotResponse is not pointing to any code.

Maybe I can manage to hardcode those model classes in the future 😃 . Or make a live document use swagger UI.

For now, you can view these document using swagger HUB:

@pjz
Copy link
Contributor Author

pjz commented Mar 27, 2019

...can I ask why protobufs are even involved? They're not part of the etcd API, are they?

@Revolution1
Copy link
Owner

https:/etcd-io/etcd/blob/master/Documentation/dev-guide/api_grpc_gateway.md

etcd v3 uses gRPC for its messaging protocol. The etcd project includes a gRPC-based Go client and a command line utility, etcdctl, for communicating with an etcd cluster through gRPC. For languages with no gRPC support, etcd provides a JSON gRPC gateway. This gateway serves a RESTful proxy that translates HTTP/JSON requests into gRPC messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants