-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated members #1712
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the
PropertyModelBase
class, a private readonly memberJsonSchemaProperty _property
is defined and populated in the constructor.Also, in the derieved
PropertyModel
class, a private readopnly memberJsonSchemaProperty _property
is defined and populated in the constructor after passing it to the base constructor.Is that not inefficient and memory waste? Would it not be a better approach to make the
JsonSchemaProperty _property
inPropertyModelBase
be protected or expose it via a read-only protected property?The text was updated successfully, but these errors were encountered: