Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CPFP for channel close transactions #675

Closed
saubyk opened this issue May 10, 2021 · 4 comments · Fixed by #1394
Closed

Enable CPFP for channel close transactions #675

saubyk opened this issue May 10, 2021 · 4 comments · Fixed by #1394
Assignees
Labels
CPFP enhancement New feature or request LND
Milestone

Comments

@saubyk
Copy link
Collaborator

saubyk commented May 10, 2021

Enable CPFP feature for channel close transactions on LND.

@saubyk saubyk added the LND label May 10, 2021
@saubyk saubyk added this to the Release 0.10.3-beta milestone May 10, 2021
@saubyk saubyk added the enhancement New feature or request label May 10, 2021
@hieblmi
Copy link

hieblmi commented Jun 21, 2021

Would this also include the CPFP feature for regular on-chain transactions?
image

@saubyk
Copy link
Collaborator Author

saubyk commented Jun 21, 2021

Hi @hieblmi this ticket specifically addresses channel close transactions only.

Onchain receipts can also be bumped up, but it would be best to cover it in a separate ticket. Additionally, from your example above, it would not be advisable to try to bump up Loop Out on chain receives with CPFP, because the loop service automatically takes care of on-chain sweeps with RBF.
You can read more about it here:
https://blog.lightning.engineering/technical/posts/2019/04/15/loop-out-in-depth.html

@hieblmi
Copy link

hieblmi commented Jun 22, 2021

Thank you @saubyk - I created a separate issue for this.
It looks like though the Loop service is only bumping the fee up to a user specified max value.
I for example set the value(block height) too low(~1sat/vbyte) hence the loop service is not RBFing/CPFPing anymore.

In these instances would it be advised to bump up manually?

Here's the text:
image

@ShahanaFarooqui
Copy link
Collaborator

Closing with PR #1394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CPFP enhancement New feature or request LND
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants