Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sky input events in free cam mode #2691

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Update sky input events in free cam mode #2691

merged 1 commit into from
Feb 19, 2021

Conversation

tritonas00
Copy link
Collaborator

Reported from discord:

You can't advance time while in free cam mode anymore

@ohlidalp
Copy link
Member

This way you'll make all these active in free-camera mode:

EV_COMMON_GET_NEW_VEHICLE
EV_COMMON_ENTER_OR_EXIT_TRUCK
EV_COMMON_ENTER_NEXT_TRUCK
EV_COMMON_ENTER_PREVIOUS_TRUCK
EV_COMMON_RESPAWN_LAST_TRUCK
EV_SKY_*
EV_COMMON_TOGGLE_TERRAIN_EDITOR

It's not a big deal but it never worked like that before.

The nicest solution would be to create GameContext::UpdateSkyInputEvents() and put both SKY* blocks there.

@tritonas00
Copy link
Collaborator Author

Oops you are right, will try to do it that way

@tritonas00
Copy link
Collaborator Author

moved sky input events in UpdateSkyInputEvents and updated main.cpp accordingly

@tritonas00 tritonas00 changed the title Update input events in free cam mode Update sky input events in free cam mode Feb 18, 2021
ohlidalp
ohlidalp approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tritonas00 tritonas00 merged commit 76a0b50 into RigsOfRods:master Feb 19, 2021
@tritonas00 tritonas00 deleted the free-cam-events branch February 19, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohlidalp ohlidalp ohlidalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tritonas00 @ohlidalp