Hotfix: only load prop mesh from own resource group. #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may break props (truck) and odef meshes (terrain) for some mods, if the mesh is located in another resource bundle.
|
It fixes train valley trains also: Master |
tritonas00
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: when 2 mods (each with it's own bundle) contain mesh with the same file name, they will clash with each other. The first mod loaded will override the mesh for all others until the game is restarted. This applies to props (vehicle) and odefs (terrain).
Cause: class MeshObject was searching for the mesh name globally instead of using the mod's resource group. This is classic behavior, some mods might rely on it.
Fix: use the mod's resource group, as already done for most resources.
Mods I used for testing:
agora-meshmix1.zip
agora-meshmix2.zip