Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduction of the number of constructors #283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reduction of the number of constructors #283

wants to merge 2 commits into from

Conversation

RobLoach
Copy link
Owner

No description provided.

@kyomawolf
Copy link
Contributor

How about doing this for the Vector2, 3, 4 classes as well?

@RobLoach
Copy link
Owner Author

yeah If we do take this approach, I'd like to do a few things...

  • Add more tests to make sure the constructors still work properly
  • Apply the same pattern across the rest of the data types

I do remember running into an issue with the initializer list understanding the default parameters, but I'm not sure where/when it happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RobLoach @kyomawolf @Bigfoot71