Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[IMPROVEMENT] Remove Markdown tags from in some parts of the app #1563

Closed
3 tasks done
rafaelks opened this issue Apr 19, 2018 · 2 comments · May be fixed by #2432
Closed
3 tasks done

[IMPROVEMENT] Remove Markdown tags from in some parts of the app #1563

rafaelks opened this issue Apr 19, 2018 · 2 comments · May be fixed by #2432
Assignees
Milestone

Comments

@rafaelks
Copy link
Contributor

rafaelks commented Apr 19, 2018

  • In-app notifications;
  • Reply/Quote pop-up;
  • Push notifications
@rafaelks rafaelks added this to the 2.3.0 milestone Apr 19, 2018
@Sameesunkaria
Copy link
Collaborator

Sameesunkaria commented Apr 19, 2018

@rafaelks for in-app notifications, the markdown should be removed from the backend.

There’s already an issue for that (posted by you) RocketChat/Rocket.Chat#9979.
You could maybe update it to mention the same requirement for desktop notifications? 🤔

@rafaelks
Copy link
Contributor Author

@Sameesunkaria For now, we can remove the markdown by simply getting the cached value on Markdown library and transforming it in pure String (.string attribute of NSAttributedString). Would you mind doing this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants