Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Emoji package to emoji-toolkit #25131

Closed
wants to merge 0 commits into from

Conversation

kotwani2883
Copy link

@kotwani2883 kotwani2883 commented Apr 9, 2022

Proposed changes (including videos or screenshots)

  • Changed the package from emojione-assets to emoji-toolkit
  • Screenshot from 2022-04-09 16-57-06

Issue(s)

#24917

Steps to test or reproduce

  • Open the Rocket.Chat App on web
  • Click on any channel on which you want to communicate
  • Emojis appearing besides the text mssg are updated using emoji-toolkit package

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2022

CLA assistant check
All committers have signed the CLA.

@kotwani2883
Copy link
Author

kotwani2883 commented Apr 9, 2022

Hi @matthias4217 this is my first PR to rocket.chat.Kindly let me know if any changes are to be made.Thanks!!

@matthias4217
Copy link
Contributor

Hi @matthias4217 this is my first PR to rocket.chat.Kindly let me know if any changes are to be made.Thanks!!

Hello ! I am not part of RocketChat, and I have never contributed to this software, except by testing things and reporting issues. Thus I'm not sure what the best practices are and I can't offer a lot of help. It seems here

In apps/meteor/package.json, lines 142 and 241, I'm don't think you need to include emojione and emojione-assets anymore, but you should add the new emoji toolkit in the devDependencies. I haven't tried any of this though, so please don't take what I say for absolute truth, and check it for yourself ! Thank you for your work anyway !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants