Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Lack of Emoji 12 or newer emoji #27782

Closed
wants to merge 5 commits into from
Closed

Conversation

MrVSiK
Copy link

@MrVSiK MrVSiK commented Jan 17, 2023

Proposed changes (including videos or screenshots)

The Emoji were missing due to a discontinued package emojione. See this readme.
In summary, the package name has changed from joypixels/emojione to joypixels/emoji-toolkit
Changes included:

  1. css sprite filenames to start with joypixels- as opposed to emojione-
  2. class names to contain joypixels as opposed to emojione
  3. import statements to use emoji-toolkit as opposed to emojione
  4. package.json to contain emoji-toolkit and emoji-assets

Issue(s)

Closes #24917

Steps to test or reproduce

Search for an Emoji 12 or newer emoji, such as 🪓

Further comments

@MrVSiK MrVSiK requested a review from a team as a code owner January 17, 2023 18:39
@MrVSiK
Copy link
Author

MrVSiK commented Feb 1, 2023

@dudanogueira Would be really grateful if you could please take a look at this PR. Thanks in advance. :))

Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project
  • This PR has an invalid title

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ggazzo ggazzo closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Emoji library
3 participants