Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #24917 ISSUE : UPDATED emojione package to emoji-toolkit #27799

Closed
wants to merge 2 commits into from
Closed

[FIX] #24917 ISSUE : UPDATED emojione package to emoji-toolkit #27799

wants to merge 2 commits into from

Conversation

21SINGH
Copy link

@21SINGH 21SINGH commented Jan 20, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Fixes #24917

Steps to test or reproduce

Further comments

@21SINGH 21SINGH requested review from a team as code owners January 20, 2023 18:42
@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@21SINGH
Copy link
Author

21SINGH commented Jan 21, 2023

this is my first time , pull resquest but from yesterday its showing review required , can anyone please help and make me understand what is going on

@casalsgh
Copy link
Contributor

this is my first time , pull resquest but from yesterday its showing review required , can anyone please help and make me understand what is going on

Hi There 21Sigh,
Highly recommend you to check Rocket.Chat development guidelines: https://handbook.rocket.chat/departments-operations/research-and-development/engineering/development/development-guidelines
Also, please check PR general guidelines and best practices -> https://handbook.rocket.chat/departments-operations/research-and-development/engineering/development/pr-general-instructions-and-handling

We need some descriptions of what is the issue you are facing and change proposal before we can take steps on reviews.
Note: Reviews are internal engineering review to code as a way to check what the PR is about, if it's working and any relevant next step related to the PR.

@casalsgh casalsgh added the stat: stale Stale issues will be automatically closed if no activity label Apr 24, 2023
@casalsgh casalsgh removed the stat: stale Stale issues will be automatically closed if no activity label Apr 24, 2023
@21SINGH 21SINGH closed this by deleting the head repository Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Emoji library
4 participants