Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record canonical paths during name resolution 2.0 #3185

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Record canonical paths during name resolution 2.0 #3185

wants to merge 1 commit into from

Conversation

powerboat9
Copy link
Contributor

No description provided.

@powerboat9
Record canonical paths during name resolution 2.0
06ebbca 
gcc/rust/ChangeLog:

	* resolve/rust-toplevel-name-resolver-2.0.cc
	(TopLevel::TopLevel): Set canonical_crate_num to
	UNKNOWN_CRATENUM by default.
	(TopLevel::insert_or_error_out): Use
	Analysis::Mappings::insert_canonical_path to record the
	canonical path of any node entered into a namespace.
	(TopLevel::go): Set canonical_crate_num to the current crate.
	(TopLevel::visit): Handle updates to canonical_stack and
	canonical_crate_num (the latter when visiting an ExternCrate).
	* resolve/rust-toplevel-name-resolver-2.0.h
	(TopLevel::canonical_stack): Add.
	(TopLevel::canonical_crate_num): Add.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
@powerboat9
Copy link
Contributor Author

It looks like this might need some tweaks

@powerboat9 powerboat9 marked this pull request as draft October 5, 2024 21:30
@powerboat9 powerboat9 mentioned this pull request Oct 9, 2024
Merged
@P-E-P
Copy link
Member

P-E-P commented Oct 10, 2024

@powerboat9 should we close this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @P-E-P