-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] VST using imgui-rs and baseview changes Ableton scaling and doesn't get the right window when Windows scaling isn't set to 100% #107
Comments
This problem also occurs on Cubase 10.5 / Windows 11. |
While working on #174 I found this very suspicious piece of code: Lines 707 to 709 in 998ced8
This is called on baseview window creation, but it changes the DPI awareness for the entire process, which might explain why other windows like Ableton and Serum's are affected. |
I doubt that's the issue, since in the parented case that call is most likely just failing (source):
Though we definitely shouldn't be calling it in the parented case anyway. |
Hello, I've talked about this issue on the discord before but I thought I'd raise a proper issue with my findings.
For some reason, when the Windows scaling isn't 100% (under setttings -> display -> make everything bigger), my baseview/imgui-rs VST changes the scaling in Ableton and is served a too small window.
In FL Studio, the window is also too small but at least the scaling doesn't change. Fl Studio doesn't seem to ever scale up VSTs.
A VST that causes the issue can be found here: https:/Fredemus/svf_filter
Before adding the vst, windows scaling set to 125%
After adding the vst, windows scaling set to 125%. Note that Serum and the channels in Ableton got smaller.
Interestingly, after adding the VST, then changing scaling to 100%, then back to 125% seems to solve the issue.
Edit: Forgot to mention, this problem didn't exist before this commit: ae2f28c
The text was updated successfully, but these errors were encountered: