Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements - GitHub workflow, make docs.rs default to macos #71

Merged
merged 5 commits into from
Dec 6, 2020

Conversation

mitchmindtree
Copy link
Member

This is a follow-up to RustAudio/coreaudio-sys#37.

  • Checks more cargo feature permutations.
  • Adds an auto-publishing action.
  • Makes sure docs.rs defaults to macos build.
  • Refers users to docs.rs for docs on readme rather than rustaudio.github.io.
  • Removes old travis CI.

@mitchmindtree
Copy link
Member Author

I think this should probably wait to land until we can work out how to solve RustAudio/coreaudio-sys#40.

@MichaelHills
Copy link
Contributor

@mitchmindtree it would be nice to get the auto-publish going. I'm trying to find some free time to finish off my cpal iOS support, so will want to publish coreaudio-rs soon.

I don't fully understand the docs.rs issue in that, does it currently work with the travis flow but not github CI or something like that? Would it be possible to have both travis + github CI to land just the auto-publishing part?

@MichaelHills MichaelHills mentioned this pull request Dec 6, 2020
@mitchmindtree
Copy link
Member Author

Thanks for the reminder about this @MichaelHills!

Yeah so far the blocker is this cross-compilation step necessary to get the documentation building in the docs.rs workflow. See here RustAudio/coreaudio-sys#38. I don't quite remember how far I got with it or why that current PR is failing.

I think it wouldn't be so bad if we landed this auto-publishing change in the meantime, as the current coreaudio-rs docs.rs documentation is useless anyway (it's a Linux build of a macOS framework). We can always get #38 working afterwords, and in the meantime users should be able to build the docs locally on macos with cargo doc --open.

These seem to be failing atm, but these should not block the rest of the
PR and auto-publishing.
@mitchmindtree mitchmindtree merged commit 4fe6e8d into RustAudio:master Dec 6, 2020
@MichaelHills
Copy link
Contributor

Ah I see, I might take a look into the cross-compilation thing after landing the cpal ios PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants