Intial support for 24 bits sample format (24bit stored on 4 bytes) #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two common ways of storing 24 bits samples: - on 4 bytes (called 24, most common) - on 3 bytes (called 24_3) With the current code, 3 bytes seems difficult to implement and would require a larger code refactoring. That being said, having at least '24' helps to work with hardware that only offer it.
abique
force-pushed
the
24bits-samples
branch
from
49ef872
to
ec22de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two common ways of storing 24 bits samples:
With the current code, 3 bytes seems difficult to implement and would require a larger code refactoring.
That being said, having at least '24' helps to work with hardware that only offer it.
Depends on #915 for successful compilation.
Replaces #914