-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SMTG] Add new object type SMTG #633
base: main
Are you sure you want to change the base?
Conversation
|
1 similar comment
|
missing an example as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some minor findings (see my comments). But I think that the AFF structure needs to be changed nearly completely. Maybe we can have a call and talk about it.
Please expect a delay for the review of this pull request. We have to clarify the language dependent fields of this object. |
Thank you for submitting your object type to the AFF Repository. After detailed discussion with @wurzka @schneidermic0 please go over my comments above and solve them. Please also solve the abaplint issues. As we discussed in a previous meeting, please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the AFF. I've added some new comments with some optional suggestions that are up to you to decide.
If you have any questions regarding my comments, feel free to reach out.
Thank you for the feedback. I changed the requested lines and uploaded the updated documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you again for adapting our suggestions. One more question from our side:
Edit: Please also sign the Contributor License Agreement as described in #633 (comment) to make all automated checks happy.
cds_view TYPE zif_aff_types_v1=>ty_object_name_30, | ||
"! <p class="shorttext">Subject</p> | ||
"! The subject of the email template | ||
email_subject TYPE c LENGTH 1024, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the email subject be required?
No description provided.