Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add JS Kyma On-Premise documentation #1850

Merged
merged 9 commits into from
Jul 3, 2024
Merged

Conversation

tomfrenken
Copy link
Member

@tomfrenken tomfrenken commented Jul 2, 2024

What Has Changed?

With this PR, we re-use the Java documentation for Kyma On-Premise connectivity, adjusted for JavaScript use.

Copy link
Member

@MatKuhr MatKuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of copy/pasting the Java docs, we could also only link to them, and only have the Executing Requests section. No strong opinion, but chances are we will forget to update both documents when updating either.

Finally, what about the gardener guide?

@tomfrenken tomfrenken requested a review from MatKuhr July 3, 2024 14:07
@MatKuhr MatKuhr merged commit 2244288 into main Jul 3, 2024
7 checks passed
@MatKuhr MatKuhr deleted the add-kyma-onpremise branch July 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants