Align Luigi Container wc clientAPI with core #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com:SAP/luigi into 3632-align-wc-Luigi-client-container-w-core
ndricimrr
commented
Feb 29, 2024
ndricimrr
requested review from
hardl,
JohannesDoberer,
VincentUllal and
camelCaseChris
as code owners
ndricimrr
commented
Mar 6, 2024
ndricimrr
commented
Mar 6, 2024
ndricimrr
changed the title
smahati
reviewed
Mar 8, 2024
| ### hasBack | ||
|
|
||
| The hasBack value to be passed to the compound micro frontend. | ||
| You can use it to mark if there is one or more preserved views. Useful when needing to show a back button. |
There was a problem hiding this comment.
Suggested change
| You can use it to mark if there is one or more preserved views. Useful when needing to show a back button. | |
| It indicates that there is one or more preserved views. Useful when you need to show a back button. |
| ### dirtyStatus | ||
|
|
||
| The dirty status value to be passed to the compound micro frontend. | ||
| Used for unsaved changes when navigating away |
There was a problem hiding this comment.
Suggested change
| Used for unsaved changes when navigating away | |
| It's used to indicate that there are unsaved changes when navigating away. |
| ### hasBack | ||
|
|
||
| The hasBack value to be passed to the web-component-based micro frontend. | ||
| You can use it to mark if there is one or more preserved views. Useful when needing to show a back button. |
There was a problem hiding this comment.
Suggested change
| You can use it to mark if there is one or more preserved views. Useful when needing to show a back button. | |
| It indicates that there is one or more preserved views. Useful when you need to show a back button. |
| ### dirtyStatus | ||
|
|
||
| The dirty status value to be passed to the web-component-based micro frontend. | ||
| Used for unsaved changes when navigating away |
There was a problem hiding this comment.
Suggested change
| Used for unsaved changes when navigating away | |
| It's used to indicate that there are unsaved changes when navigating away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3632