Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename files and fields #35

Merged
merged 5 commits into from
Jun 13, 2024
Merged

Rename files and fields #35

merged 5 commits into from
Jun 13, 2024

Conversation

kalena
Copy link
Contributor

@kalena kalena commented Jun 13, 2024

Changes

  • Update some file and field names according to Salesforce Quip doc, e.g., FieldLabelControllerTest.cls to FieldLabelController_Test.cls (add hyphen), fieldApiName vs fieldAPIName (make consistent)

@kalena kalena requested a review from pickettd June 13, 2024 09:49
@kalena kalena self-assigned this Jun 13, 2024
@kalena kalena requested a review from roanbear June 13, 2024 11:06
roanbear
roanbear reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@roanbear roanbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about the download links as in #34

@kalena
Copy link
Contributor Author

kalena commented Jun 13, 2024

@roanbear This pull request was specifically for the file and field name changes. Since the pull request with the README file had not been approved yet, it is rolled into subsequent pull requests under files changed.

@roanbear roanbear self-requested a review June 13, 2024 12:19
pickettd
pickettd approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@pickettd pickettd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR now has no files changed because of other PRs

@pickettd pickettd merged commit 2dbc9d2 into main Jun 13, 2024
1 check passed
@pickettd pickettd deleted the feature/naming-jun2024 branch June 13, 2024 22:01
@pickettd pickettd restored the feature/naming-jun2024 branch June 13, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickettd pickettd pickettd approved these changes

@roanbear roanbear Awaiting requested review from roanbear

Assignees

@kalena kalena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalena @pickettd @roanbear