Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for pip's change in behavior #1053

Merged
merged 4 commits into from
Apr 24, 2019
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
name: Install dependencies
command: |
virtualenv venv
venv/bin/pip install $(grep black requirements_dev.txt | cut -d';' -f 1)
venv/bin/pip install --no-use-pep517 $(grep black requirements_dev.txt | cut -d';' -f 1)
- run:
name: Run black
command: |
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
name: Install Python dependencies
command: |
virtualenv venv
venv/bin/pip install -r requirements_dev.txt
venv/bin/pip install --no-use-pep517 -r requirements_dev.txt
- run:
name: Install sfdx
command: |
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:
name: Install Python dependencies
command: |
virtualenv venv
venv/bin/pip install -r requirements_dev.txt
venv/bin/pip install --no-use-pep517 -r requirements_dev.txt
- run:
name: Check out CumulusCI-Test
command: |
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Ready to contribute? Here's how to set up CumulusCI for local development.
2. Clone your fork to your local workspace.
3. Create a fresh virtual environment using virtualenv and install development requirements::

$ pip install -r requirements_dev.txt
$ pip install --no-use-pep517 -r requirements_dev.txt

4. Install ``pre-commit`` hooks for ``black`` and ``flake8``::

Expand Down
6 changes: 2 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,5 @@ setenv =

commands = coverage run {envbindir}/pytest []

; If you want to make tox run the tests with the same versions, create a
; requirements.txt with the pinned versions and uncomment the following lines:
deps =
-r{toxinidir}/requirements_dev.txt
install_command =
python -m pip install --no-use-pep517 -r {toxinidir}/requirements_dev.txt