update dependencies including github3.py #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the tests that broke... |
added 4 commits
February 14, 2022 11:30
jstvz
approved these changes
Feb 14, 2022
Comment on lines
+36
to
+37
| # Work around normalized name of github3.py distribution | ||
| req = req.replace("github3-py", "github3.py") |
There was a problem hiding this comment.
Huh. Figured setuptools/wheel would do the right thing here.
There was a problem hiding this comment.
Yeah -- I think there's probably a bug somewhere in there, but I hit my timebox for locating it and decided to do this instead.
| # via -r requirements/prod.in | ||
| github3.py==3.0.0 | ||
| github3-py==3.1.0 |
There was a problem hiding this comment.
I think it's from this change in pip-tools: jazzband/pip-tools#1572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some tidying of github actions configuration
Critical Changes
Changes
Issues Closed