Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SalesforcePlaywright.py #3626

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GeekStewie
Copy link

  • Suggested change: Increase default timeout to 90 seconds as 15 seconds is not long enough for some processes and browser will incorrectly timeout

  • Suggested change, increase viewport size as some items get truncated and robot doesn't find them. 1080x1920 has been ok for us without issue.

- Suggested increase default timeout to 90 seconds as 15 seconds is not long enough for some processes
- Suggested change, increase viewport size as some items within tables get truncated and robot sometimes misses them. 1080x1920 has been ok for us without issue.
@GeekStewie GeekStewie marked this pull request as ready for review July 18, 2023 20:40
@GeekStewie GeekStewie requested a review from a team as a code owner July 18, 2023 20:40
@GeekStewie
Copy link
Author

Added some additional keywords which we use in Q brix which can be really helpful

@davidmreed
Copy link
Contributor

@GeekStewie Unfortunately we no longer have a Robot Framework expert on our team (still less a Playwright expert). These changes make perfect sense to me, and I assume you're using them in production?

Could you add Robot tests in cumulusci/robotframework/tests/salesforce/playwright/playwright.robot?

@GeekStewie
Copy link
Author

GeekStewie commented Aug 7, 2023 via email

@GeekStewie
Copy link
Author

@GeekStewie Unfortunately we no longer have a Robot Framework expert on our team (still less a Playwright expert). These changes make perfect sense to me, and I assume you're using them in production?

Could you add Robot tests in cumulusci/robotframework/tests/salesforce/playwright/playwright.robot?

Can you confirm what test needs to be added here? The changes apply to the Open test browser keyword which is already tested for in these tests in the suite setup and teardown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants