Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IJson and IDecompressor have no virtual destructor #47

Closed
matthew-nagy opened this issue Nov 10, 2021 · 1 comment
Closed

IJson and IDecompressor have no virtual destructor #47

matthew-nagy opened this issue Nov 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@matthew-nagy
Copy link
Contributor

Despite being pure virtual classes, their destructors have not been explicitly marked as virtual. This can cause derrived classes to not have their destructors called correctly.
It also makes clang++ on linux throw me a warning a mile long, and adding these changes to my forked version fixed these issues. If you'd like, I can create a pull request.

@SSBMTonberry SSBMTonberry added the bug Something isn't working label Nov 11, 2021
@SSBMTonberry SSBMTonberry added this to the Version 1.3.1 milestone Nov 11, 2021
@SSBMTonberry
Copy link
Owner

Thanks for your issue! 🙂
Feel free to create a pull request on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants