Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure TiledEnum values can be properly read from Objects and Tiles #87

Closed
SSBMTonberry opened this issue Dec 2, 2022 · 0 comments · Fixed by #98
Closed

Make sure TiledEnum values can be properly read from Objects and Tiles #87

SSBMTonberry opened this issue Dec 2, 2022 · 0 comments · Fixed by #98
Assignees
@SSBMTonberry
Labels
bug Something isn't working
Milestone
Version 1.4.0

Comments

@SSBMTonberry
Copy link
Owner

SSBMTonberry commented Dec 2, 2022 •
edited
Loading

In many ways related to #79 .

Didn't look like EnumValues on objects could resolve any EnumDefinition when loaded.
This must be fixed to properly support Tiled 1.8

Things to test:

  • All enum types has a modified value with definition when retrieving from:
    • A class
    • An object
    • A tile
@SSBMTonberry SSBMTonberry added the bug Something isn't working label Dec 2, 2022
@SSBMTonberry SSBMTonberry added this to the Version 1.4.0 milestone Dec 2, 2022
@SSBMTonberry SSBMTonberry self-assigned this Dec 2, 2022
@SSBMTonberry SSBMTonberry mentioned this issue Dec 2, 2022
Closed
4 tasks
SSBMTonberry added a commit that referenced this issue Dec 11, 2022
@SSBMTonberry
Added unfinished test for the future fix of issue #87
ac782af
@SSBMTonberry SSBMTonberry mentioned this issue May 15, 2023
Closed
@SSBMTonberry SSBMTonberry mentioned this issue May 27, 2023
Closed
@SSBMTonberry SSBMTonberry mentioned this issue Aug 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SSBMTonberry SSBMTonberry

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.4.0
Development

Successfully merging a pull request may close this issue.

Fix for unresolved TiledEnum values SSBMTonberry/tileson
1 participant
@SSBMTonberry