RD2: Fixing a bug where the Installment Number does not appear #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow when RD Type is Fixed by default
lparrott
commented
Oct 14, 2021
| @@ -121,6 +121,10 @@ export default class rd2EntryFormScheduleSection extends LightningElement { | |||
|
|
|||
| this.disableInstallmentFrequencyField = this.shouldDisableField(response.InstallmentFrequencyPermissions); | |||
| this.hideInstallmentFrequencyField = this.shouldHideField(response.InstallmentFrequencyPermissions); | |||
|
|
|||
| let recurringType = this.getRecurringType(); | |||
There was a problem hiding this comment.
I'd like to add a Jest test for this, if possible, hoping to look into it next week.
There was a problem hiding this comment.
Since we don't have Jest tests for this component yet, I'm going to skip testing this via Jest (for now)
bdvorachek
approved these changes
Oct 18, 2021
andrewyu-salesforce
approved these changes
Oct 19, 2021
added 2 commits
October 19, 2021 16:02
…dDefault__jest rd2EntryForm - Include default recurring type in mock, update fixed RD tests
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI: W-9047953
Fixes #6318
Critical Changes
Changes
Fixes and Minor Enhancements
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata