Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gift Entry: Exclude Deleted Field Mappings When Generating Default Template #6721

Merged

Conversation

klewis-sfdc
Copy link
Contributor

@klewis-sfdc klewis-sfdc commented Oct 28, 2021

Critical Changes

Changes

Gift Entry

  • Deleted field mappings are now excluded when the default Gift Entry template is generated.

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

klewis-sfdc and others added 13 commits October 28, 2021 07:36
added to the default template when generated

Todos:
- Mock Selector and remove SeeAllData
- Try filtering IsDeleted out of query to simplify
added to the default template when generated

Todos:
- Mock Selector and remove SeeAllData
- Try filtering IsDeleted out of query to simplify
comment explaining why the order is important
…rationIsDeleted' into feature/235__defaultTemplateGenerationIsDeleted

# Conflicts:
#	force-app/main/default/classes/GE_Template.cls
#	force-app/main/default/classes/GE_Template_TEST.cls
@klewis-sfdc klewis-sfdc marked this pull request as ready for review November 2, 2021 23:27
Copy link
Contributor

@psadie-sfdo psadie-sfdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments!

force-app/main/default/classes/GE_GiftEntryController.cls Outdated Show resolved Hide resolved
force-app/main/default/classes/GE_Template.cls Outdated Show resolved Hide resolved
force-app/main/default/classes/GE_Template.cls Outdated Show resolved Hide resolved
force-app/main/domain/FieldMappings.cls-meta.xml Outdated Show resolved Hide resolved
force-app/main/selector/FieldMappingSelector.cls-meta.xml Outdated Show resolved Hide resolved
@psadie-sfdo psadie-sfdo merged commit 9aa1594 into feature/235 Nov 4, 2021
@psadie-sfdo psadie-sfdo deleted the feature/235__defaultTemplateGenerationIsDeleted branch November 4, 2021 20:29
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Nov 4, 2021
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants