Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Contact Deletion from Non-Household Accounts #6767

Merged

Conversation

klewis-sfdc
Copy link
Contributor

@klewis-sfdc klewis-sfdc commented Dec 7, 2021

W-10227258

Critical Changes

Changes

Issues Closed

Fixes #6755

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

into an Org Account does not rename the Org Account
@klewis-sfdc klewis-sfdc marked this pull request as ready for review December 8, 2021 14:13
Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Ken! Just added a few comments.

to validate that an NPE will not be encountered in the case that
the IndividualBucketAccount.cls name prop is referenced before the Account exists
in the org
@daniel-fuller daniel-fuller self-requested a review December 9, 2021 10:57
Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ken!

Copy link
Contributor

@force2b force2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, but I'm recommending a change to the unit tests that would help ensure it catches any async operations.

Copy link
Contributor

@psadie-sfdo psadie-sfdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, listed test scenarios all pass! Thanks, Ken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants