Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing "total" from RD Migration JSON to free up space in field #6824

Merged
merged 12 commits into from
Feb 7, 2022

Conversation

lparrott
Copy link
Contributor

@lparrott lparrott commented Jan 25, 2022

  • We removed the "total" count of processed records from the Enhanced Recurring Donation migration JSON in custom settings, since it can be calculated using the failed and processed amounts.

Critical Changes

Changes

Issues Closed

  • Known Issue: Customers with greater than 99,999 Recurring Donations will receive a "STRING_TOO_LONG" error when they upgrade to Enhanced Recurring Donations

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

Comment on lines 104 to 106
setTotalRecords() {
this.batchJob.summary.total = this.batchJob.summary.processed + this.batchJob.summary.failed;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd change this up a tiny bit to add that total property on to the object before assigning it to this.batchJob. Here's a suggestion below:

Suggested change
setTotalRecords() {
this.batchJob.summary.total = this.batchJob.summary.processed + this.batchJob.summary.failed;
}
setTotalRecords(data) {
if(!isNull(data)) {
data.summary.total = data.summary.processed + data.summary.failed;
return data;
}
return null;
}

Then with that, we could do something like:

this.batchJob = setTotalRecords(JSON.parse(data));

@daniel-fuller daniel-fuller self-requested a review January 26, 2022 17:48
Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Contributor

@npsp-reedestockton npsp-reedestockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution - simple and effective!

@daniel-fuller daniel-fuller merged commit d561f09 into feature/238 Feb 7, 2022
@daniel-fuller daniel-fuller deleted the feature/238__rdMigrationRemoveTotal branch February 7, 2022 19:33
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants