Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-10288878: Work Elevate - Ingest Tribute Information - Part 1/2 #6848

Conversation

grivero
Copy link
Contributor

@grivero grivero commented Feb 11, 2022

W-10288878: Work Elevate - Ingest Tribute Information - Part 1/2

  • New custom metadata fields to support tribute info mapping

  • New custom fields to support tribute info

  • Updates on Install script to create tribute mappings

  • Updates on Donation layout to include new tribute custom fields

  • new Custom Metadata Types:

    • Data_Import_Field_Mapping.Donation_Honoree_Information.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Honoree_Name.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Notification_Message.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Notification_Preference.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Notification_Recipient_Email.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Notification_Recipient_Info.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Notification_Recipient_Name.md-meta.xml
    • Data_Import_Field_Mapping.Donation_Tribute_Type.md-meta.xml

Critical Changes

Changes

Import or Enter Tribute Gifts

  • We added tribute gift fields to Gift Entry and NPSP Data Importer. The new fields on the NPSP Data Import object map to the Tribute fields on the Opportunity. These fields also work with tributes on Elevate Giving Pages.
  • Update your users' permissions for the new fields:
    • NPSP Data Import object:
      • Donation_Honoree_Information__c
      • Donation_Honoree_Name__c
      • Donation_Notification_Message__c
      • Donation_Notification_Preference__c
      • Donation_Notification_Recipient_Email__c
      • Donation_Notification_Recipient_Info__c
      • Donation_Notification_Recipient_Name__c
      • Donation_Tribute_Type__c
    • Opportunity object:
      • Honoree_Information__c
      • Notification_Recipient_Email__c
      • Tribute_Notification_Date__c
      • Tribute_Notification_Status__c
  • If you have existing NPSP Data Import fields and mappings for the Opportunity tribute fields, we recommend deleting your old fields and mappings and use the packaged ones instead.

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

  • Fields:
    • DataImport__c.Donation_Honoree_Information__c
    • DataImport__c.Donation_Honoree_Name__c
    • DataImport__c.Donation_Notification_Message__c
    • DataImport__c.Donation_Notification_Preference__c
    • DataImport__c.Donation_Notification_Recipient_Email__c
    • DataImport__c.Donation_Notification_Recipient_Info__c
    • DataImport__c.Donation_Notification_Recipient_Name__c
    • DataImport__c.Donation_Tribute_Type__c
    • Opportunity.Honoree_Information__c
    • Opportunity.Notification_Recipient_Email__c
    • Opportunity.Tribute_Notification_Date__c
    • Opportunity.Tribute_Notification_Status__c

Deleted Metadata

@grivero grivero self-assigned this Feb 11, 2022
@grivero grivero marked this pull request as ready for review February 11, 2022 05:52
…ElevateIngestTributeInfo' into feature/238__grivero-W-10288878-ElevateIngestTributeInfo
@mldyang
Copy link
Contributor

mldyang commented Feb 11, 2022

Looks good.
Currently, the Feature Test is failing. But, it doesn't seem to be related to this work. I re-started the build to see if that will resolve the issue.

@klewis-sfdc
Copy link
Contributor

Looks good. Currently, the Feature Test is failing. But, it doesn't seem to be related to this work. I re-started the build to see if that will resolve the issue.

Looks like the rebuild passed. And I can confirm that the tests that failed on the first run are flaky and fail occasionally.

<trackFeedHistory>false</trackFeedHistory>
<trackTrending>false</trackTrending>
<type>TextArea</type>
<type>LongTextArea</type>
<visibleLines>10</visibleLines>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field type change should be fine when upgrading existing orgs, right? I think this is the equivalent of modifying the length of a text field as mentioned here: https://developer.salesforce.com/docs/atlas.en-us.packagingGuide.meta/packagingGuide/modifying_custom_fields.htm. @grivero Is that your understanding also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenlewis-sfdo, this type of conversion is allowed and it's safe to update field type.
This article also have good notes about field conversion: https://help.salesforce.com/s/articleView?id=sf.notes_on_changing_custom_field_types.htm&type=5

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Thanks, @grivero

Copy link
Contributor

@callen-sfdo callen-sfdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested, looks good.

@callen-sfdo callen-sfdo merged commit 492a4c6 into feature/238 Feb 17, 2022
@callen-sfdo callen-sfdo deleted the feature/238__grivero-W-10288878-ElevateIngestTributeInfo branch February 17, 2022 21:59
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants