RD2: Consolidate Payment Widget State into App State object #6855
Conversation
…d2FormBillingAddress
…x' into feature/238__rd2FormBillingAddress
…om/SalesforceFoundation/NPSP into feature/238__rd2FormBillingAddress
…nge type and payment method.
…, fix for Worldpay token params
…to feature/238__rd-payment-state
bdvorachek
changed the base branch from
feature/238__rd2FormBillingAddress
to
feature/238
lparrott
requested review from
andrewyu-salesforce
and removed request for
andrewyu-salesforce
…forceFoundation/NPSP into feature/238__rd-payment-state
…nts, update rd2EntryForm tests. Remove unused JSON mocks for getRecurringSettings/getRecurringData. Move crud/fls check into getInitialView.
|
|
||
| this.isLoading = disableBtn; |
There was a problem hiding this comment.
I think this change is preventing error messages from appearing, the Loading spinner stays visible, hiding the error.
There was a problem hiding this comment.
Good catch! I think we may need to add a line to handleError to disable the loading spinner to fully replicate the former behavior of setSaveButtonDisabled. Will see if that fix works and get a test in there for it if so.
…anges from CC to ACH
…forceFoundation/NPSP into feature/238__rd-payment-state
| @AuraEnabled(Cacheable=true) | ||
| public static Boolean hasRequiredFieldPermissions() { | ||
| @TestVisible | ||
| private static Boolean hasRequiredFieldPermissions() { |
There was a problem hiding this comment.
For the collection of fields here, could we use String.valueOf(SObject.FieldName)? That way with other fields are added in the future that are not in the underlying packages, we don't have to worry about including namespace.
|
|
||
| view.hasRequiredPermissions = hasRequiredFieldPermissions(); | ||
| if(!view.hasRequiredPermissions) { | ||
| return view; |
There was a problem hiding this comment.
What were your thoughts here regarding returning an empty view instead of an AuraHandledException like we do in other AuraEnabled methods in this class?
There was a problem hiding this comment.
Honestly, it was closer to the original behavior of the component. I think we could do that here too and have that be our standard. Any AuraEnabled function that a user does not have the correct level of permissions for would throw an exception.
…th getInitialView.
… get namespace aware fieldnames.
WI: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00000cEQzOYAW/view
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata