Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed references to Power of Us Hub #6859

Merged
merged 33 commits into from
Feb 25, 2022
Merged

Conversation

sam-knox
Copy link
Contributor

@sam-knox sam-knox commented Feb 21, 2022

Updated labels, objects, and other components to remove references to the Power of Us Hub.

Critical Changes

Changes

Fixes and Minor Enhancements

  • We removed references and links to the Power of Us Hub and replaced them with links to the Trailblazer community.

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@sam-knox sam-knox requested a review from a team as a code owner February 21, 2022 18:11
@github-actions
Copy link

Hi 👋 @sam-knox! Release Engineering asks that teams use the following process for routine reviews:

  1. After creating a non-draft pull request that includes automation updates, a release engineer will be auto-assigned to the PR.
  2. When dev review is complete and the PR is ready for the release engineer to review, add a "ready for RE review" label to the PR to let us know when the PR is ready for us to review.
  3. If you've added the "ready for RE review" label but haven't received a review within a 36 hours, @-mention the assigned RE in a comment on the PR.
  4. If you don't receive a response from the assigned RE by the end of the next business day (or your request is urgent), post a message to #sfdo-releng-support that includes a link to this PR and one of us will review as soon as we're able.

@lparrott lparrott changed the base branch from main to feature/238 February 22, 2022 21:05
@@ -53,7 +53,7 @@ public with sharing class UTIL_HtmlOutput_CTRL {

/** @description The map of allowed urls and their temporary substitution values */
private static final Map<String, String> SUBSTITUTION_BY_ALLOWED_URL = new Map<String, String> {
'<a href="https://powerofus.force.com/' => '|hubURL|',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should stay the same since it's used to "allow" certain URLs to be included in Custom Labels (I'll push a revert for this)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok. Sorry about that!

@lparrott lparrott removed request for a team and seshmannepalli February 23, 2022 20:54
Copy link
Contributor

@daniel-fuller daniel-fuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Sam!

@lparrott lparrott merged commit 6dc0363 into feature/238 Feb 25, 2022
@lparrott lparrott deleted the feature/238__sam_W-10483321 branch February 25, 2022 21:12
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Feb 25, 2022
@@ -2,20 +2,16 @@

#### For Users

* <a href="https://powerofus.force.com" target="_blank">Ask questions or get help</a>
* <a href="https:/SalesforceFoundation/NPSP/issues/new" target="_blank">Log a confirmed Issue</a> or <a href="https://powerofus.force.com/hub-ideas" target="_blank">Feature Request</a>
* <a href="https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE?tab=discussion&sort=LAST_MODIFIED_DATE_DESC" target="_blank">Ask questions or get help</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-knox - I was just looking through our PRs and saw this one. Any chance we could change the link from Github Issues to the Known Issues page? We recently migrated all issues over to that site. And instead of saying "Log a confirmed issue", maybe switch to "View Confirmed Issues"?

* <a href="https://powerofus.force.com/NPSP_Documentation" target="_blank">User Documentation</a>
* Check out existing <a href="https:/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://powerofus.force.com/hub-ideas?product=NPSP" target="_blank">feature and enhancement requests.</a>
* Check out existing <a href="https:/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Success%20Pack]" target="_blank">feature and enhancement requests.</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sam-knox - and same with this mention of 'bugs' -- maybe link to Known Issues instead?
https://trailblazer.salesforce.com/issues_index?tag=SFDO%20Nonprofit%20Success%20Pack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesslopez-sf : Yeah we can update that. The switch to Known Issues happened (or we knew of it) well after we made these initial updates to remove the Hub references. I can ask the devs about this, but being that it's near the end of the development cycle I'll wait until after feature freeze.

I imagine there's similar updates needed in other repos too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants