-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed references to Power of Us Hub #6859
Conversation
Hi 👋 @sam-knox! Release Engineering asks that teams use the following process for routine reviews:
|
@@ -53,7 +53,7 @@ public with sharing class UTIL_HtmlOutput_CTRL { | |||
|
|||
/** @description The map of allowed urls and their temporary substitution values */ | |||
private static final Map<String, String> SUBSTITUTION_BY_ALLOWED_URL = new Map<String, String> { | |||
'<a href="https://powerofus.force.com/' => '|hubURL|', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should stay the same since it's used to "allow" certain URLs to be included in Custom Labels (I'll push a revert for this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, ok. Sorry about that!
…deploy-labels Updated links to point to Trailblazer groups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Sam!
@@ -2,20 +2,16 @@ | |||
|
|||
#### For Users | |||
|
|||
* <a href="https://powerofus.force.com" target="_blank">Ask questions or get help</a> | |||
* <a href="https:/SalesforceFoundation/NPSP/issues/new" target="_blank">Log a confirmed Issue</a> or <a href="https://powerofus.force.com/hub-ideas" target="_blank">Feature Request</a> | |||
* <a href="https://trailhead.salesforce.com/trailblazer-community/groups/0F94S000000kHitSAE?tab=discussion&sort=LAST_MODIFIED_DATE_DESC" target="_blank">Ask questions or get help</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-knox - I was just looking through our PRs and saw this one. Any chance we could change the link from Github Issues to the Known Issues page? We recently migrated all issues over to that site. And instead of saying "Log a confirmed issue", maybe switch to "View Confirmed Issues"?
* <a href="https://powerofus.force.com/NPSP_Documentation" target="_blank">User Documentation</a> | ||
* Check out existing <a href="https:/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://powerofus.force.com/hub-ideas?product=NPSP" target="_blank">feature and enhancement requests.</a> | ||
* Check out existing <a href="https:/SalesforceFoundation/NPSP/labels/bug" target="_blank">bugs</a> and <a href="https://ideas.salesforce.com/s/search#t=All&sort=relevancy&f:@sfcategoryfull=[Nonprofit%7CNonprofit%20Success%20Pack]" target="_blank">feature and enhancement requests.</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sam-knox - and same with this mention of 'bugs' -- maybe link to Known Issues instead?
https://trailblazer.salesforce.com/issues_index?tag=SFDO%20Nonprofit%20Success%20Pack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesslopez-sf : Yeah we can update that. The switch to Known Issues happened (or we knew of it) well after we made these initial updates to remove the Hub references. I can ask the devs about this, but being that it's near the end of the development cycle I'll wait until after feature freeze.
I imagine there's similar updates needed in other repos too.
Updated labels, objects, and other components to remove references to the Power of Us Hub.
Critical Changes
Changes
Fixes and Minor Enhancements
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata