Fixing regression where RD2 Change Type is not set without value change #6924
Conversation
| @@ -134,7 +135,7 @@ const getDonationValue = (state) => { | |||
|
|
|||
| const getChangeType = (state) => { | |||
| if (isRecurringTypeChanged(state) || isNewRecord(state)) { | |||
| return ""; | |||
| return state.changeType; | |||
There was a problem hiding this comment.
Doing this allows a manual change to the picklist to "stick" even if the overall Value changed, which is in line with our current release.
There was a problem hiding this comment.
I think this is the only thing that needs to change in this PR. I believe that an empty string is the correct return value for when the recurring type is changed or when the record is new. There's one test that fails if we return state.changeType:
open donation, when amount changed and recurring type changed to fixed, blanks change type picklist
I've added a test for manual changes sticking in commit 6b99fdf called "open donation, persists manual change to change type picklist".
There was a problem hiding this comment.
Yup, I thought about this last night after you reached out, I'll make the change and do a bit more testing!
There was a problem hiding this comment.
Just pushed a fix, thanks for adding that Jest test 👍
|
Added to #6928 |
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata