Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work NPSP MultiCurrency Customers on the One-to-One Account Model May Receive Null Pointer Exceptions When Inserting a Contact on Hyperforce Instances #6950

Merged
merged 5 commits into from
May 12, 2022

Conversation

daniel-fuller
Copy link
Contributor

Add a safe navigation operator to avoid exceptions when executing legacy rollups.

Critical Changes

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

Copy link
Contributor

@lparrott lparrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested this fix with the bug scenario on a falcon org, the error goes away with this change 👍

Copy link
Contributor

@voduyemi voduyemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @dfuller114

@daniel-fuller
Copy link
Contributor Author

@voduyemi re-requested your review once more. Realized the unit test should only run on multi-currency enabled orgs or the SOQL query on CurrencyIsoCode will fail. Also removed an unused code line.

@davidmreed davidmreed merged commit aed15a9 into main May 12, 2022
@davidmreed davidmreed deleted the feature/falconMultiCurrencyError branch May 12, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants