Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SFCA -- Trust/Security][Implementation] Address potential security vulnerabilities in NPSP (CRLP) #6976

Merged
merged 2 commits into from
Jun 8, 2022
Merged

[SFCA -- Trust/Security][Implementation] Address potential security vulnerabilities in NPSP (CRLP) #6976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
614f3fc
add annotation to ignore these classes for SFCA scan
daniel-fuller Jun 7, 2022
94f9eca
add clarifying comment for SFCA bypass
daniel-fuller Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions force-app/main/default/classes/CMT_FilterRule_SEL.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@
* @group CMT Filter Rules
* @description Selector class for FilterGroups and FilterRule Custom Metadata Type objects
*/
// Adding custom rule to avoid this class being scanned by the SFCA scanner since we will not enforce FLS for
// customizable rollups.
/* sfge-disable ApexFlsViolationRule */
public without sharing class CMT_FilterRule_SEL {

/**
Expand Down
3 changes: 3 additions & 0 deletions force-app/main/default/classes/CRLP_RollupUI_SVC.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
* @description Lightning Component Server Controller for the Rollups UI page CRLP_Setup.
*/

// Adding custom rule to avoid this class being scanned by the SFCA scanner since we will not enforce FLS for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful comment. Should it be included in CMT_FilterRule_SEL as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Just added!

// customizable rollups.
/* sfge-disable ApexFlsViolationRule */
public with sharing class CRLP_RollupUI_SVC {

private static final String SUCCESS_RESPONSE = 'SUCCESS';
Expand Down