Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[W-10874727] - Elevate NonElevate Filter #6988

Merged
merged 26 commits into from
Jun 29, 2022
Merged

[W-10874727] - Elevate NonElevate Filter #6988

merged 26 commits into from
Jun 29, 2022

Conversation

gerardorodriguezsf
Copy link
Contributor

@gerardorodriguezsf gerardorodriguezsf commented Jun 17, 2022 •
edited by melissabarber
Loading

Technical Design Review

[Technical Design Review] W-10874727 - NPSP

  • Updated the RD2_ETableController to get the ‘Recurring Donation’ LWC field ‘Show these types of Recurring Donations’ with the selected option from the Experience Builder. Updated RD2_ERecurringDonationsSelector to return only the filtered recurring donation records.

Changes

Work Closed

W-10874727

maurimart
maurimart approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@maurimart maurimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

force2b
force2b requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@force2b force2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on hardcoded strings, but this PR also has a merge conflict that needs resolution in order to complete the review.

force-app/main/default/classes/RD2_ERecurringDonationsSelector.cls Outdated Show resolved Hide resolved
JoseRossiSF
JoseRossiSF approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@JoseRossiSF JoseRossiSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerardorodriguezsf gerardorodriguezsf added the CX High Priority PRs labeled with this should be reviewed before the end of sprint label Jun 21, 2022
force2b
force2b requested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@force2b force2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing tabs everywhere. Please check all of the files in this PR as well as with your other teammates to make sure that nobody else is using tabs

force2b
force2b requested changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@force2b force2b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a build failure due to a class compilation issue. Same as with the 6991 PR.

force-app/main/default/classes/RD2_ERecurringDonationsSelector.cls Outdated Show resolved Hide resolved
@lparrott lparrott removed the request for review from force2b June 28, 2022 13:55
@alvaroolivenciasf alvaroolivenciasf removed the request for review from voduyemi June 28, 2022 16:59
@nadiasanchez nadiasanchez merged commit 7d49cfd into feature/240 Jun 29, 2022
@nadiasanchez nadiasanchez deleted the feature/240__filter_rd_elevate_nonelevate branch June 29, 2022 17:15
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroolivenciasf alvaroolivenciasf alvaroolivenciasf left review comments

@lparrott lparrott lparrott approved these changes

@JoseRossiSF JoseRossiSF JoseRossiSF approved these changes

@maurimart maurimart maurimart approved these changes

@force2b force2b Awaiting requested review from force2b

@voduyemi voduyemi Awaiting requested review from voduyemi

Assignees

@nadiasanchez nadiasanchez

Labels
CX High Priority PRs labeled with this should be reviewed before the end of sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gerardorodriguezsf @force2b @voduyemi @lparrott @alvaroolivenciasf @JoseRossiSF @maurimart @nadiasanchez