Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix NPSP push failures when encryption is enabled #7010

Merged
merged 7 commits into from
Jul 5, 2022

Conversation

lparrott
Copy link
Contributor

@lparrott lparrott commented Jun 27, 2022

W-11140971

Critical Changes

Changes

  • Encrypted fields no longer block push upgrades to 238 (NPSP 3.217).

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

@voduyemi voduyemi self-requested a review June 27, 2022 15:09
Copy link
Contributor

@voduyemi voduyemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but how can we definitively test this to be sure it won't be a problem for future pushes?

@lparrott
Copy link
Contributor Author

This looks good, but how can we definitively test this to be sure it won't be a problem for future pushes?

Without knowing which fields customers have encrypted, it's impossible to know for sure 😩 This particular issue has come up with quite a few orgs though, so it's a start!

@daniel-fuller daniel-fuller self-requested a review June 30, 2022 17:24
@daniel-fuller
Copy link
Contributor

daniel-fuller commented Jun 30, 2022

This looks good, but how can we definitively test this to be sure it won't be a problem for future pushes?

The only definitive way would be to not use DML for contacts so we wouldn't need to query them.

@voduyemi voduyemi self-requested a review July 5, 2022 18:12
@daniel-fuller daniel-fuller merged commit 799cb42 into feature/240 Jul 5, 2022
@daniel-fuller daniel-fuller deleted the feature/240__fixEncryptionTestFailure branch July 5, 2022 18:16
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants