Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w-9537427 avoid use of implicit headings #7237

Conversation

salesforce-suyash-more
Copy link
Contributor

Critical Changes

GUS W-9537427
Updated :

  1. CustomLabels.labels-meta.xml : Label RD2_EnablementMigrationCompleteMessage is modified with h4 heading tag for 'Upgrade process complete!' heading.
  2. batchProgress.html : 'Data Migration Run' heading is surrounded by h2 heading tag.

Changes

Issues Closed

Community Ideas Delivered

Features Intended for Future Release

Features for Elevate Customers

New Metadata

Deleted Metadata

'Upgrade process complete' heading is marked with a heading tag <h4> to overcome accessibility issue.
'Data Migration Run' was only styled to look like headings but wasn’t marked as such, hence added h2 heading tag explicitly.
Copy link
Contributor

@ptewson-sfdo ptewson-sfdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@salesforce-suyash-more
Copy link
Contributor Author

salesforce-suyash-more commented Jun 28, 2024

@ptewson-sfdo do you think we should close this PR if everything appears to be in order?

@ptewson-sfdo ptewson-sfdo merged commit 9b9096f into feature/252 Jul 1, 2024
6 of 11 checks passed
@ptewson-sfdo ptewson-sfdo deleted the feature/252__W-9537427-avoid-use-of-implicit-headings branch July 1, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants