Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase CRUD and FLS checks #519

Merged
merged 34 commits into from
Jul 21, 2022
Merged

Increase CRUD and FLS checks #519

merged 34 commits into from
Jul 21, 2022

Conversation

jjbennett
Copy link
Contributor

@jjbennett jjbennett commented Jun 29, 2022 •
edited
Loading

Critical Changes

Changes

  • We have increased CRUD and FLS checks on several pages:
    • Job Calendar
      • When using the Shift Calendar as an internal user, if you no longer have a list of campaigns or a list of jobs to choose from in the dropdowns. Please verify you have read permissions for the Active field on the Campaign object.
      • When missing read access on any other field used on the page you will receive an error message letting you know which field is missing access.
    • Personal Site Contact Info
      • Guest users will no longer see fields or data related to fields they do not have read access to. If the guest site user no longer sees fields on the volunteer hours, is missing the data chart or rankings please verify they have access to all related fields.
    • Send Bulk Email
    • Volunteers Bulk Enter Hours
    • Volunteers Campaign Wizard
    • Volunteers Job Listing
    • Volunteers Job Listing FS

Issues Closed

New Metadata

Deleted Metadata

@jjbennett jjbennett changed the title WIP: Update access checks when needed, bypass scanner when verified. Increase CRUD and FLS checks Jul 8, 2022
@jjbennett
Copy link
Contributor Author

W-11280104

@jjbennett jjbennett requested a review from a team as a code owner July 8, 2022 22:09
@jjbennett jjbennett requested review from jstvz and removed request for a team July 8, 2022 22:09
@jstvz jstvz removed their request for review July 12, 2022 19:40
abalimane
abalimane reviewed Jul 13, 2022
View reviewed changes
src/classes/VOL_Access.cls Outdated Show resolved Hide resolved
src/classes/VOL_CTRL_PersonalSiteContactInfo.cls Show resolved Hide resolved
src/classes/VOL_CTRL_SendBulkEmail.cls Outdated Show resolved Hide resolved
src/classes/VOL_CTRL_SendBulkEmail.cls Show resolved Hide resolved
src/classes/VOL_CTRL_VolunteersBulkEnterHours.cls Outdated Show resolved Hide resolved
jjbennett and others added 13 commits July 15, 2022 08:49
@jjbennett
Disable scanner, access checks and strip inaccessible are being done.
d6c639b
@jjbennett
Additional access checks.
aca1e28
@jjbennett
Update comment to new scanner version prefix.
184be05
@salesforce-org-metaci
Merge 184be05 into feature/240__scanner-updates__more-updates
49bc699
@jjbennett
Additional access checks.
187e1ad
@jjbennett
Merge branch 'feature/240__scanner-updates__more-updates' of github.c…
fef2f2d 
…om:SalesforceFoundation/Volunteers-for-Salesforce into feature/240__scanner-updates__more-updates
@jjbennett
Additional access checks.
fbc2015
@jjbennett
Fix errors and ensure npsp fields exist before accessesing them.
41b1d70
@jjbennett
Sanitize url parameter before using it in a query.
67dd38b
@jjbennett
Add test internal user permission set.
dcb068f
@jjbennett
Add test internal user permission set.
8c32335
@jjbennett
Add missing namespace tokens
97cf2f7
@AndersonTarren
Merge pull request #520 from SalesforceFoundation/feature/240__scanne…
e7d5ae8 
…r-updates__more-updates

Additional access checks
@AndersonTarren AndersonTarren merged commit 14504ff into feature/240 Jul 21, 2022
@AndersonTarren AndersonTarren deleted the feature/240__scanner-updates branch July 21, 2022 18:22
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalimane abalimane abalimane left review comments

Assignees

@abalimane abalimane

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjbennett @abalimane @AndersonTarren