Add regression tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosthekiss
requested changes
Jan 3, 2019
|
@DanielBallaSZTE In your next update, please add the test cases of the recently fixed issues #31 and #33 . |
DanielBallaSZTE
force-pushed
the
regression-tests
branch
from
410a151
to
286ecf4
Compare
|
@akosthekiss Patch updated, thank you for the review. |
akosthekiss
requested changes
Jan 4, 2019
DanielBallaSZTE
force-pushed
the
regression-tests
branch
2 times, most recently
from
7f7aa46
to
0998653
Compare
akosthekiss
requested changes
Jan 4, 2019
DanielBallaSZTE
force-pushed
the
regression-tests
branch
from
0998653
to
3435a45
Compare
|
@akosthekiss Thank you for the review, PR updated |
akosthekiss
reviewed
Jan 5, 2019
DanielBallaSZTE
force-pushed
the
regression-tests
branch
2 times, most recently
from
5466420
to
955d2ec
Compare
akosthekiss
reviewed
Jan 9, 2019
DanielBallaSZTE
force-pushed
the
regression-tests
branch
from
955d2ec
to
9295895
Compare
|
@akosthekiss I have updated the PR with the suggested changes, thank you |
akosthekiss
requested changes
Jan 11, 2019
DanielBallaSZTE
force-pushed
the
regression-tests
branch
2 times, most recently
from
52391ac
to
073ee65
Compare
|
#53 should land to make Travis pass. |
DanielBallaSZTE
force-pushed
the
regression-tests
branch
2 times, most recently
from
76c1245
to
393f198
Compare
Now regression tests for resolved issues can be added to the project. Regression tests are enabled by default. They can be manually run by appending `regression-tests` to the `run-tests.py` command. There is an `expected-failures` directory for tests that should fail. The .gitignore file was modified as well to making sure it doesn't ignore these testfiles. Signed-off-by: Daniel Balla [email protected]
DanielBallaSZTE
force-pushed
the
regression-tests
branch
from
393f198
to
587eb0f
Compare
|
@akosthekiss I've updated the PR, since #53 landed, Travis will probably take some time to run, however it should pass since my local travis passed as well. |
clover2123
referenced
this pull request
in clover2123/escargot
Jan 22, 2019
Now regression tests for resolved issues can be added to the project. Regression tests are enabled by default. They can be manually run by appending `regression-tests` to the `run-tests.py` command. There is an `expected-failures` directory for tests that should fail. The .gitignore file was modified as well to making sure it doesn't ignore these testfiles. Signed-off-by: Daniel Balla [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression-teststo therun-tests.pycommand.expected-failuresdirectory for tests that should fail.The .gitignore file was modified as well to making sure it doesn't ignore these testfiles.
Signed-off-by: Daniel Balla [email protected]